There are some \linebreaks introduced which should be \brk{}; otherwise I couldn't find anything wrong.

As I understand it, \brk (aka \discretionary) is basically \-, and I use \- where ever possible. So the fact that I resorted to \linebreak most likely meant that \brk wouldn't work in those cases. Do you know of any cases where using \brk would have made a difference?

As I understand it, \brk (aka \discretionary) is basically \-, and I use \- where ever possible.

Yeah, with the exception that it won't leave a hyphen at line wraps (unless \discretionary is configured to do so, which it isn't for \brk).

So the fact that I resorted to \linebreak most likely meant that \brk wouldn't work in those cases. Do you know of any cases where using \brk would have made a difference?

Can you just replace any use of \linebreak with \brk{} and see if that fixes it? I have drafted up many thousands of TeX LOCs for these motions, and I yet have to encounter a case where \linebreak works but \brk doesn't.

\- sometimes doesn't work because it's not in the right spot for paragraph justification to feel incentivized enough to break the line there, but if you throw in enough \-s in the midlde of words and \brk{} after punctuation etc., then it always seems to work. It's just a matter of drowning the \tcodes in enough line break opportunities until it works.

Jens also replaced a bunch of \linebreaks with \brks and that worked just fine in any of his PRs.